Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernises the Meta-class and changes its faction to NT #2566

Merged
merged 22 commits into from
Mar 23, 2024

Conversation

Zevotech
Copy link
Contributor

@Zevotech Zevotech commented Dec 6, 2023

About The Pull Request

The Meta was a comfy little whiteship in dire need of fixing. It had tinyfans, light fixture frames and an uncomfortably cramped kitchen and botany area. This PR remaps it while keeping its soul intact, making it an old Nanotrasen vessel instead of an Indie.

NEW META (NO AREAS):
StrongDMM-2023-12-06 00 54 04

NEW META (AREAS):
StrongDMM-2023-12-06 00 54 00

NEW META (INGAME):
image

OLD META (NO AREAS):
StrongDMM-2023-12-05 17 42 10

Why It's Good For The Game

I don't want this pretty good ship to be removed for being old and having tinyfans. Having another NT ship that fills a logistics/cargo niche is also pretty great.

Changelog

🆑
add: Remapped the Meta-class and changed its faction to NT
/:cl:

@Zevotech Zevotech requested a review from a team as a code owner December 6, 2023 06:01
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Dec 6, 2023
@github-actions github-actions bot added the Code change Watch something violently break. label Dec 6, 2023
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jan 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jan 26, 2024
@Luftkommando
Copy link
Contributor

firefox_iPH2WeBRkR

The APC isn't wired into the network. Cable shows unpowered in-game. Probably best to run it through the airlock instead of the wall.

@Zevotech
Copy link
Contributor Author

lol holy shit how did I miss that. I'll fix it ASAP. oops! wallcable!

@Martinpachu
Copy link
Contributor

The captain has an independant captain's outfit and not Nanotrasen.

@Zevotech
Copy link
Contributor Author

Got it. Jobs were from before the outfit paths got updated so they slipped through.

@Martinpachu
Copy link
Contributor

you can add more captain slots??

@Zevotech
Copy link
Contributor Author

you can add more captain slots??

oh my god this fucking ship

Copy link
Member

@Latentish Latentish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kill the ORM

_maps/configs/nanotrasen_meta.json Outdated Show resolved Hide resolved
@Latentish
Copy link
Member

Cool thanks merging now.

@Latentish Latentish enabled auto-merge March 6, 2024 12:25
@Latentish Latentish added this pull request to the merge queue Mar 22, 2024
Merged via the queue into shiptest-ss13:master with commit 126ac4d Mar 23, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Mar 24, 2024
…3#2566)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
The Meta was a comfy little whiteship in dire need of fixing. It had
tinyfans, light fixture frames and an uncomfortably cramped kitchen and
botany area. This PR remaps it while keeping its soul intact, making it
an old Nanotrasen vessel instead of an Indie.

NEW META (NO AREAS):
![StrongDMM-2023-12-06 00 54
04](https://github.com/shiptest-ss13/Shiptest/assets/95449138/bd542fdb-8de4-462e-bc48-c7f8e49e2b41)

NEW META (AREAS):
![StrongDMM-2023-12-06 00 54
00](https://github.com/shiptest-ss13/Shiptest/assets/95449138/a6ea0332-18f4-466b-a65b-19dd1d08da1f)

NEW META (INGAME):

![image](https://github.com/shiptest-ss13/Shiptest/assets/95449138/d2eff008-052a-4bd9-99ab-7d14170ec156)

OLD META (NO AREAS):
![StrongDMM-2023-12-05 17 42
10](https://github.com/shiptest-ss13/Shiptest/assets/95449138/d1a8c051-3cb4-4846-a357-731526c8a7e9)
I don't want this pretty good ship to be removed for being old and
having tinyfans. Having another NT ship that fills a logistics/cargo
niche is also pretty great.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
add: Remapped the Meta-class and changed its faction to NT
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Mar 27, 2024
…3#2566)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
The Meta was a comfy little whiteship in dire need of fixing. It had
tinyfans, light fixture frames and an uncomfortably cramped kitchen and
botany area. This PR remaps it while keeping its soul intact, making it
an old Nanotrasen vessel instead of an Indie.

NEW META (NO AREAS):
![StrongDMM-2023-12-06 00 54
04](https://github.com/shiptest-ss13/Shiptest/assets/95449138/bd542fdb-8de4-462e-bc48-c7f8e49e2b41)

NEW META (AREAS):
![StrongDMM-2023-12-06 00 54
00](https://github.com/shiptest-ss13/Shiptest/assets/95449138/a6ea0332-18f4-466b-a65b-19dd1d08da1f)

NEW META (INGAME):

![image](https://github.com/shiptest-ss13/Shiptest/assets/95449138/d2eff008-052a-4bd9-99ab-7d14170ec156)

OLD META (NO AREAS):
![StrongDMM-2023-12-05 17 42
10](https://github.com/shiptest-ss13/Shiptest/assets/95449138/d1a8c051-3cb4-4846-a357-731526c8a7e9)

## Why It's Good For The Game
I don't want this pretty good ship to be removed for being old and
having tinyfans. Having another NT ship that fills a logistics/cargo
niche is also pretty great.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Remapped the Meta-class and changed its faction to NT
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to FalloutFalcon/ShiptestF that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants